CASSANDRA-20752: Add SSTableFlushObserver#onSSTableWriterSwitched #4380
+407
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavshenoy
force-pushed
the
sstableindex_flushing
branch
2 times, most recently
from
9981933 to
c446387
Compare
maedhroz
reviewed
Oct 6, 2025
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentBuilder.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
test/unit/org/apache/cassandra/index/sai/functional/CompactionTest.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
maedhroz
reviewed
Oct 6, 2025
test/unit/org/apache/cassandra/index/sai/functional/CompactionTest.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
test/unit/org/apache/cassandra/io/sstable/SSTableFlushObserverTest.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
src/java/org/apache/cassandra/index/sai/disk/v1/SSTableIndexWriter.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
| boolean emptySegment = currentBuilder == null || currentBuilder.isEmpty(); | ||
| logger.debug("Flushing index {} with {}buffered data on sstable writer switched...", index.identifier().indexName, emptySegment ? "no " : ""); | ||
| if (!emptySegment) | ||
| flushSegment(); |
There was a problem hiding this comment.
Note that we don't have to aggressively create a new builder here because addTerm(), complete(), and abort() will all handle the currentBuilder == null case appropriately.
maedhroz
reviewed
Oct 6, 2025
src/java/org/apache/cassandra/index/sai/disk/PerColumnIndexWriter.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
src/java/org/apache/cassandra/index/sai/disk/PerColumnIndexWriter.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 6, 2025
src/java/org/apache/cassandra/index/sai/disk/StorageAttachedIndexWriter.java
Outdated
Show resolved
Hide resolved
maedhroz
requested changes
Oct 6, 2025
pranavshenoy
force-pushed
the
sstableindex_flushing
branch
2 times, most recently
from
5f2deb4 to
55d7132
Compare
… SAI segment builder for written shards without waiting for entire transaction to complete (apache#1859) This reduces memory usage during sharded compaction. riptano/cndb#14725 OOM during SAI compaction with large num of shards Flush segment builder when sstable writer is switched to free memory without waiting full compaction to complete
pranavshenoy
force-pushed
the
sstableindex_flushing
branch
from
55d7132 to
27dbb77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SSTableFlushObserver#onSSTableWriterSwitched to flush SAI segment builder for written shards without waiting for entire transaction to complete
This reduces memory usage during sharded compaction.
The Cassandra Jira